Document the VLC prefix loops and avoid u32 wrap in dec_vlc_read() - #297
Merged
Merged
Conversation
kpchoi
changed the title
Signed-off-by: KP Choi <19379257+kpchoi@users.noreply.github.com>
Signed-off-by: KP Choi <19379257+kpchoi@users.noreply.github.com>
Signed-off-by: KP Choi <19379257+kpchoi@users.noreply.github.com>
kpchoi
force-pushed
the
comment_vlc_k_check
branch
from
September 29, 2026 02:37
1282525 to
3fed5b7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dec_vlc_read_kparam0(),dec_vlc_read_1bit_read()anddec_vlc_read()explaining whykis not range-checked inside the loops and how a malformed bitstream is rejected.dec_vlc_read(), add the exp-golomb prefix sum once after thekcheck instead of per bit, sosymbolcannot wrap on a malformed bitstream.KPARAM_*()macros explaining why no lower clamp is applied.