Guard payload_type and payload_size against u32 overflow in oapvd_vlc_metadata() - #292
Merged
kpchoi merged 1 commit intoSep 28, 2026
Conversation
…_metadata() Check that payload_type and payload_size do not wrap 32-bit unsigned integers when accumulating 0xFF bytes in oapvd_vlc_metadata(). Signed-off-by: Fyodor Kyslov <kyslov@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Prevents 32-bit unsigned integer wraparound in
oapvd_vlc_metadata()(src/oapv_vlc.c):payload_typeandpayload_size0xFFaccumulation loops with<= (0xFFFFFFFFU - 255)and<= (0xFFFFFFFFU - t0)before adding255ort0.Testing
ctestunit/conformance tests pass with AddressSanitizer and UndefinedBehaviorSanitizer.