Bug fix: Translation of semi transmissive standard surface materials to gltf_pbr#2912
Open
bowald wants to merge 2 commits into
Open
Bug fix: Translation of semi transmissive standard surface materials to gltf_pbr#2912bowald wants to merge 2 commits into
bowald wants to merge 2 commits into
Conversation
bowald
changed the title
bowald
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR address translation of semi transmissive standard surface materials to gltf_pbr.
It closes #2898.
A mix node has been added taking the transmission weight into account. The weight have been square as it better matches the final result.
The translation is not perfect, the base color will be more influence by either transmission color (if transmission_depth=0) or white in when transmission weight approaches 1. It would be nice if its more correct, and I would love some input from anyone with more knowledge about standard surface and gltf_pbr how to mix it to get a better result.
For anyone reconstructing this issue, note that attenuation color in gltf_pbr is not implemented, so use white translation color/attenuation color when comparing the materials.
Here are the result with the updates to the translation graph
Reference
Translation
Diff