REFACTOR: Use integer station index with separate station_name coord#35
Closed
rcjackson wants to merge 1 commit into
Closed
REFACTOR: Use integer station index with separate station_name coord#35rcjackson wants to merge 1 commit into
rcjackson wants to merge 1 commit into
Conversation
The station dim now holds 0..N-1 integer indices and station_name is a separate string coord, replacing the prior layout where station itself held string identifiers. Adds a _station_index helper for name->int lookup (with a back-compat fallback for legacy datasets), updates the in-situ matching path to select by integer index, and lets the vis helpers accept either names or indices. Also fixes a latent bug where nexrad_columns was unconditionally dereferenced when nexrad=False. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Collaborator
Author
|
Throwing this one out, we don't need to do this after all. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactoring to where the station is now an integer and there is a station_name variable describing the station. This helps improve compliance with ARM/cf standards.