Repository navigation
Filter and sort computed fields by a DQL expression - #318
Merged
TomHAnderson merged 1 commit intoOct 4, 2026
Merged
TomHAnderson merged 1 commit into
TomHAnderson merged 1 commit into
Conversation
A ComputedField may give an expression, the DQL of its value. The field
then has filters, sort and sortPriority among them, applied to the
expression as a field's are applied to its column.
- Every alias in an expression is a {placeholder}, renamed on each use,
so two filters, or a filter and a sort, on one field do not collide.
{entity} is the root entity. {:name} is the argument name, bound from
the filter's args, else its default, else null.
- A sort selects the expression AS HIDDEN and orders by it. The batch
id-pair query keeps the hidden selects when it replaces the select; the
batch count query applies no sorts (Filter\QueryBuilder::apply() takes
$sort).
- Each expression is parsed with Query::getAST(), without a database,
after the metadata.build event. Invalid DQL, an alias without a
placeholder, an unknown {:name}, an expression on a list or an entity
type, and excluded filters without an expression throw
Exception\Metadata.
- DQL takes a subquery only for comparisons, so between is applied as two
comparisons, and the in, notin, isnull and LIKE filters DQL rejects for
an expression are added to its excludeFilters in the metadata.
- excludeFilters and includeFilters on ComputedField limit its filters.
The expression and excludeFilters keys are left out of the metadata of
a field without them, so Metadata::FORMAT_VERSION is unchanged.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 14.1.x #318 +/- ##
==========================================
Coverage ? 100.00%
Complexity ? 1276
==========================================
Files ? 81
Lines ? 3490
Branches ? 0
==========================================
Hits ? 3490
Misses ? 0
Partials ? 0 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A ComputedField may give an expression, the DQL of its value. The field then has filters, sort and sortPriority among them, applied to the expression as a field's are applied to its column.