Repository navigation
Make the sortFields config a bool - #317
Merged
TomHAnderson merged 1 commit intoOct 3, 2026
Merged
Conversation
sortFields was bool|null with a null default, which meant the same as false. It is now a bool, false by default, and Config::getSortFields() returns a bool. Passing null throws Exception\Configuration. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 14.0.x #317 +/- ##
===========================================
Coverage 100.00% 100.00%
Complexity 1199 1199
===========================================
Files 80 80
Lines 3238 3238
===========================================
Hits 3238 3238 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sortFields was bool|null with a null default, which meant the same as false. It is now a bool, false by default, and Config::getSortFields() returns a bool. Passing null throws Exception\Configuration.