Skip to content

Reject an association to an entity not exposed in the group - #311

Merged
TomHAnderson merged 1 commit into
API-Skeletons:14.0.xfrom
TomHAnderson:hotfix/unexposed-association-target
Oct 2, 2026
Merged

TomHAnderson merged 1 commit into
API-Skeletons:14.0.xfrom
TomHAnderson:hotfix/unexposed-association-target

Conversation

@TomHAnderson

Copy link
Copy Markdown
Member

An #[Association] to an entity with no #[Entity] attribute of the group failed every query of its entity's type, even one which did not ask for the association, with an error naming only the entity it refers to. It now throws Exception\Metadata naming the association when the metadata is built.

The check runs after the metadata.build event, so a listener may add the entity, and removing one another refers to is an error. The check of a computed field of an entity type moves after the event with it.

Two test groups had such an association, on entities their tests never query; their targets are now exposed in those groups.

An #[Association] to an entity with no #[Entity] attribute of the
group failed every query of its entity's type, even one which did not
ask for the association, with an error naming only the entity it refers
to.  It now throws Exception\Metadata naming the association when the
metadata is built.

The check runs after the metadata.build event, so a listener may add the
entity, and removing one another refers to is an error.  The check of a
computed field of an entity type moves after the event with it.

Two test groups had such an association, on entities their tests never
query; their targets are now exposed in those groups.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@TomHAnderson
TomHAnderson merged commit dc70501 into API-Skeletons:14.0.x Oct 2, 2026
11 checks passed
@codecov

codecov Bot commented Oct 2, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (d148c83) to head (8a25132).
⚠️ Report is 3 commits behind head on 14.0.x.

Additional details and impacted files
@@             Coverage Diff             @@
##              14.0.x      #311   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
- Complexity      1142      1147    +5     
===========================================
  Files             79        79           
  Lines           3088      3100   +12     
===========================================
+ Hits            3088      3100   +12     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant