Repository navigation
Hotfix/identifier conversion coverage - #310
Merged
TomHAnderson merged 2 commits intoOct 2, 2026
Merged
TomHAnderson merged 2 commits into
TomHAnderson merged 2 commits into
Conversation
- Test that a batched collection target removed after its identifier is selected, as by another request, is left off its page. The test base can now run a function just before a statement executes. - Test a to-one association to an entity whose identifier is an association, whose identifier the to-one loader binds as it is. - Remove a null identifier check which converting the identifier makes redundant, and a check that DBAL's type names are strings. - Bind an entity without an identifier as itself, for Doctrine to report, rather than reading an identifier it does not have. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Also name the coverage scripts composer.json has; composer coverage does not exist. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 14.0.x #310 +/- ##
=============================================
+ Coverage 99.87% 100.00% +0.12%
+ Complexity 1143 1142 -1
=============================================
Files 79 79
Lines 3091 3088 -3
=============================================
+ Hits 3087 3088 +1
+ Misses 4 0 -4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.