Skip to content

Promote the uneven-4-way partition disable to speed 1 - #5305

Open
chengchen-google wants to merge 1 commit into
AOMediaCodec:av2-encfrom
chengchen-google:experiment/patch_0021
Open

Promote the uneven-4-way partition disable to speed 1#5305
chengchen-google wants to merge 1 commit into
AOMediaCodec:av2-encfrom
chengchen-google:experiment/patch_0021

Conversation

@chengchen-google

Copy link
Copy Markdown
Contributor

The speed feature was enabled at speed 2.
It turns out that its performance at speeed 1 is also good.

On speed 1, RA, the tradeoff is:

Testset PSNR-YUV EncSpeedUp Ratio
A1 (17 frames) 0.03% 6.23% 207.7
A2 (33 frames) 0.06% 6.70% 111.7

STATS_CHANGED

The speed feature was enabled at speed 2.
It turns out that its performance at speeed 1 is also good.

On speed 1, RA, the tradeoff is:

Testset 	PSNR-YUV EncSpeedUp 	Ratio
A1 (17 frames) 	0.03% 	 6.23% 		207.7
A2 (33 frames) 	0.06% 	 6.70% 		111.7

STATS_CHANGED

Change-Id: I10706c1ed77881e8d185f80e2a7a04b456eb6474
@urvangjoshi

Copy link
Copy Markdown
Contributor

What is the anchor @chengchen-google for these results?
I saw a bigger loss on commit 2abcfff:

  • 0.13% average loss w/o B2
  • 0.06% on A1
  • 0.08% on A2
  • 0.19% on B1
  • 0.19% on A3
  • 0.34% on A4
  • Neutralish on A5 but most clips have a loss

If you see something similar, I'd suggest disabling based on resolution (1080+) and also keeping it on for screen content perhaps?

@chengchen-google

Copy link
Copy Markdown
Contributor Author

What is the anchor @chengchen-google for these results? I saw a bigger loss on commit 2abcfff:

  • 0.13% average loss w/o B2
  • 0.06% on A1
  • 0.08% on A2
  • 0.19% on B1
  • 0.19% on A3
  • 0.34% on A4
  • Neutralish on A5 but most clips have a loss

If you see something similar, I'd suggest disabling based on resolution (1080+) and also keeping it on for screen content perhaps?

The anchor is 5d628d8.
I haven't tested for other resolutions. I do have an impression that the performance change on lower resolutions is larger. Do you think we need the full information to make a decision? If other resolution shows larger loss, perhaps we can make this speed feature dependent on resolution?

@urvangjoshi

Copy link
Copy Markdown
Contributor

What is the anchor @chengchen-google for these results? I saw a bigger loss on commit 2abcfff:

  • 0.13% average loss w/o B2
  • 0.06% on A1
  • 0.08% on A2
  • 0.19% on B1
  • 0.19% on A3
  • 0.34% on A4
  • Neutralish on A5 but most clips have a loss

If you see something similar, I'd suggest disabling based on resolution (1080+) and also keeping it on for screen content perhaps?

The anchor is 5d628d8. I haven't tested for other resolutions. I do have an impression that the performance change on lower resolutions is larger. Do you think we need the full information to make a decision? If other resolution shows larger loss, perhaps we can make this speed feature dependent on resolution?

Yes, pls run other resolutions (RA 33 frames) and let's make a decision based on the result -- resolution dependent was indeed my suggestion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants