Remove local var bfirst in check_frame_unit_data() - #5278
Merged
urvangjoshi merged 1 commit intoAug 19, 2026
Conversation
A simple analysis shows that the local variables bfirst and vcl_found in check_frame_unit_data() are always opposite to each other. Remove bfirst and replace it with !vcl_found.
urvangjoshi
force-pushed
the
cleanup-check_frame_unit_data
branch
from
August 18, 2026 23:37
b4d6504 to
8319c13
Compare
urvangjoshi
approved these changes
Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A simple analysis shows that the local variables bfirst and vcl_found in check_frame_unit_data() are always opposite to each other. Remove bfirst and replace it with !vcl_found.