Handle near zero coefficients in tcq - #5261
Open
jingninghan wants to merge 4 commits into
Open
Conversation
jingninghan
force-pushed
the
tcq1
branch
3 times, most recently
from
August 13, 2026 22:24
97e008b to
dda4211
Compare
Contributor
|
Is there a description for this change (or bug#)? How about coding gain? |
jingninghan
marked this pull request as draft
August 17, 2026 18:28
jingninghan
force-pushed
the
tcq1
branch
3 times, most recently
from
August 18, 2026 21:32
fb7db6f to
f62f020
Compare
jingninghan
marked this pull request as ready for review
August 18, 2026 21:34
jingninghan
requested review from
leolzhao,
urvangjoshi,
yeqing-wu and
yunqingwang1
August 18, 2026 21:38
Contributor
Author
Added both. ptal thanks |
Contributor
|
I'm curious about the BDrate change. It's minor, but I'd expect it to be closer to neutral. |
Contributor
Author
Yes, i think that's mainly due to constraining it to only 0 and 1 levels. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add functions to handle the coefficients that are quantized to 1.
In such cases, there is no need to check upper abs levels in the
trellis framework, and hence reducing the complexity.
Anchor: b5bb354
Test condition: CTC, RA, 33 frames, speed 1