Call memcpy() in avm_[highbd_]convolve_copy_*() - #5258
Merged
Conversation
wantehchang
commented
Aug 12, 2026
jzern
approved these changes
Aug 12, 2026
jjustiss-apple
approved these changes
Aug 12, 2026
urvangjoshi
enabled auto-merge (squash)
August 12, 2026 23:25
wantehchang
commented
Aug 13, 2026
wantehchang
marked this pull request as draft
August 13, 2026 17:02
auto-merge was automatically disabled
August 13, 2026 17:02
Pull request was converted to draft
wantehchang
force-pushed
the
convolve-copy-memcpy
branch
from
August 19, 2026 20:26
181dbb8 to
77f4d60
Compare
wantehchang
marked this pull request as ready for review
August 19, 2026 20:27
urvangjoshi
enabled auto-merge (squash)
August 19, 2026 20:29
Call memcpy() instead of memmove() in avm_convolve_copy_*() and avm_highbd_convolve_copy_*(). avm_highbd_convolve_copy_avx2() and avm_highbd_convolve_copy_sse2() do not handle overlapping src and dst buffers when w is 256, so it is not necessary to call memmove().
wantehchang
force-pushed
the
convolve-copy-memcpy
branch
from
August 19, 2026 20:35
77f4d60 to
1dd6acf
Compare
Member
Author
|
Urvang: I just updated the commit message to reflect my latest findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.