Refactor av2_rd_pick_intra_sby_mode() - #5235
Conversation
SamuthirikaS
changed the title
|
@yunqingwang1 @urvangjoshi We have verified that this PR is bit-exact for speeds 0 to 3 across RA, LD, and AI configurations on a few test clips. Please review. Note: Each commit in this PR is logically independent and has its own commit message. Please do not squash them. |
As the gain of FSC mode is mainly for class B2, have you tested class B2 video sequences to see whether it has any bitstream change or not? @SamuthirikaS |
Hi @leolzhao, We have verified the changes are bit-exact on a B2 content |
Thanks, the MR looks good to me. Please rebase the code and fix the conflicts. @SamuthirikaS |
c873f99 to
388fe18
Compare
Refactor av2_rd_pick_intra_sby_mode() to evaluate Forward Skip Coding (FSC) modes using an outer fsc_mode loop, eliminating redundant candidate search logic and unifying non-FSC and FSC intra mode evaluation.
This patch refactors and abstracts different pruning logics within the intra mode evaluation loop into a new function and also avoids redundant computations in intra mode loop. This is a bit-exact change.
Abstracted code related to multi winner mode processing into a helper function `refine_winner_intra_mode_tx`. Also replaces memcpy with `av2_copy_array()`.
This patch renames variables in av2_rd_pick_intra_sby_mode() for better readablity and code consistency.
- Updated comments to adhere to coding guidelines. - Used local variables to avoid repetitive access from data structures. - Modified code logic for better readability.
Abstracted code related to luma intra mode cost calculation into a helper function to improve readability.
388fe18 to
4655865
Compare
4 participants
No description provided.