decoder: check profile interop conformance ASAP - #5181
Merged
urvangjoshi merged 1 commit intoAug 17, 2026
Merged
Conversation
wantehchang
commented
Jul 30, 2026
Contributor
|
@xinzhao-apple : pls review |
xinzhao-apple
approved these changes
Aug 13, 2026
xinzhao-apple
left a comment
xinzhao-apple
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me, thanks Wan-Teh, approving.
Contributor
|
Sorry for delayed response, I just swapped my primary email to my company email. |
read_sequence_header_obu() should call av2_check_profile_interop_conformance() as soon as it has read all the members of seq_params checked by that function. This allows the av2_max_level_bitrate() call in read_sequence_header_obu() to assume seq_params->seq_profile_idc is a supported profile. Document the members of seq_params checked by av2_check_profile_interop_conformance().
urvangjoshi
force-pushed
the
decoder-check_profile_interop_conformance-asap
branch
from
August 13, 2026 17:32
9bbefed to
4dcb960
Compare
urvangjoshi
enabled auto-merge (squash)
August 13, 2026 17:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
read_sequence_header_obu() should call
av2_check_profile_interop_conformance() as soon as it has read all the members of seq_params checked by that function. This allows the av2_max_level_bitrate() call in read_sequence_header_obu() to assume seq_params->seq_profile_idc is a supported profile.
Document the members of seq_params checked by
av2_check_profile_interop_conformance().