bmcweb: Fix Storage URI Endpoint Failure#62
Open
ankitaprasad2206 wants to merge 1 commit intointeg_sp8from
Open
bmcweb: Fix Storage URI Endpoint Failure#62ankitaprasad2206 wants to merge 1 commit intointeg_sp8from
ankitaprasad2206 wants to merge 1 commit intointeg_sp8from
Conversation
During BMC Upstream sync from 2.16 to 2.18, lead to failure of
logic to read Type property for Drive URI. Moved the code to be
similar as before where Type property is read directly from the
string literal exposed on dbus by iodevices-inventory.
Tested: tested On congo UI. Storage info is populated without any internal error.
'''
{
"@odata.id": "/redfish/v1/Systems/system/Storage/1/Drives/Drive0",
"@odata.type": "#Drive.v1_7_0.Drive",
"CapacityBytes": 1000204886016,
"Id": "Drive0",
"Links": {
"Chassis": {
"@odata.id": "/redfish/v1/Chassis/HPM"
}
},
"Manufacturer": "Samsung SSD 990 EVO 1TB ",
"MediaType": "NVMe",
"Model": "Samsung SSD 990 EVO 1TB ",
"Name": "Drive0",
"SerialNumber": "S7M3NS0Y215061W ",
"Status": {
"State": "Enabled"
}
}
'''
Signed-off-by: ankprasa <ankprasa@amd.com>
ashok2ku
approved these changes
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During BMC Upstream sync from 2.16 to 2.18, lead to failure of logic to read Type property for Drive URI. Moved the code to be similar as before where Type property is read directly from the string literal exposed on dbus by iodevices-inventory.
Tested: tested On congo UI. Storage info is populated without any internal error.
'''
{
"@odata.id": "/redfish/v1/Systems/system/Storage/1/Drives/Drive0", "@odata.type": "#Drive.v1_7_0.Drive",
"CapacityBytes": 1000204886016,
"Id": "Drive0",
"Links": {
"Chassis": {
"@odata.id": "/redfish/v1/Chassis/HPM"
}
},
"Manufacturer": "Samsung SSD 990 EVO 1TB ",
"MediaType": "NVMe",
"Model": "Samsung SSD 990 EVO 1TB ",
"Name": "Drive0",
"SerialNumber": "S7M3NS0Y215061W ",
"Status": {
"State": "Enabled"
}
}
'''