fix e2e vllm mixed correctless - #160
Open
limou102 wants to merge 2 commits into
Open
Conversation
limou102
requested review from
JohnQinAMD,
jiejingzhangamd and
xiaobochen-amd
as code owners
September 8, 2026 13:50
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The change is small and localized, with only a minor documentation mismatch noted for follow-up.
Pull request overview
This PR updates the vLLM mixed PD E2E matrix configuration to change the KV cache dtype setting for the GLM-5.1-FP8 case, likely to address correctness issues seen under the previous forced fp8 KV-cache setting.
Changes:
- Switch
--kv-cache-dtypefor the GLM-5.1-FP8 mixed vLLM E2E row from"fp8"to"auto".
File summaries
| File | Description |
|---|---|
| tests/e2e/pd_mixed/vllm/matrix.py | Adjusts the vLLM launch args for the GLM-5.1-FP8 mixed E2E case (KV cache dtype). |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+245
to
+247
| "args": [ | ||
| "--kv-cache-dtype", | ||
| "fp8", | ||
| "auto", |
Signed-off-by: LI MOU <lxglbk@gmail.com>
limou102
force-pushed
the
dev/limou/fix_longcontext_probe
branch
from
September 9, 2026 02:20
66c3da0 to
7415750
Compare
Signed-off-by: LI MOU <lxglbk@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.