Repository navigation
fix(web): 第三方登录回跳页 /login/oauth/<provider> 不再答 404 - #186
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
变更摘要 / Summary
go/internal/web/app.go的appPrefixes）加/login/oauth/。部署 feat(accounts): GitHub 与 Google 登录，关闭普通账号口令登录的开关 #185 后发现回跳页/login/oauth/github答 404，GitHub / Google 授权完回不到控制台。/login下其余子路径仍不是页面（测试守住/login/x）。/login/oauth/to the console SPA routes; the OAuth callback page answered 404 after feat(accounts): GitHub 与 Google 登录，关闭普通账号口令登录的开关 #185 was deployed.关联 issue / Related issues
Refs #184
测试 / Testing
go test ./internal/web/（TestIsAppRoute加两条回跳路径）GET https://app.armadra.com/login/oauth/github?code=x&state=y答 404检查清单 / Checklist