Add VBench benchmarking suite and scripts - #475
Open
jitendra-jalwaniya wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces a VBench evaluation workflow for MaxDiffusion, specifically tailored for Wan text-to-video models. It adds TPU generation and GPU evaluation scripts, utility helpers, and a downsampled 110-prompt benchmark dataset. The feedback suggests improving the robustness and portability of the scripts by using POSIX-compliant disk space checks, always enforcing virtual environment creation to avoid PEP 668 issues, and explicitly specifying UTF-8 encoding when reading and writing files.
jitendra-jalwaniya
force-pushed
the
vbench
branch
from
September 11, 2026 05:51
9f9995d to
83dd965
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR introduces a standardized
benchmarks/framework to MaxDiffusion, starting with the VBench video-generation benchmark integration. It provides an end-to-end, two-stage evaluation pipeline tailored for Wan text-to-video (T2V) models: generating videos on Google Cloud TPU and evaluating quality dimensions on GPU.Key Changes
1. Benchmark Framework & Documentation
benchmarks/README.md: Establishes the organizational guidelines for adding runnable benchmark suites and evaluation metadata across models.benchmarks/vbench/README.md: Detailed workflow documentation, parameter references, and usage examples for running locally or remotely via SSH.2. Dataset & Metadata
benchmarks/vbench/prompts_110.txt: A curated 110-prompt downsampled subset from the VBench benchmark.benchmarks/vbench/VBench_full_info_sub110.json: Aligned evaluation metadata covering all relevant VBench quality and semantic dimensions corresponding 1-to-1 with the prompt file.3. Generation & Evaluation Automation
benchmarks/vbench/run_tpu_generation.sh:--ssh).gs://<bucket>/<run-name>/videos.benchmarks/vbench/run_gpu_eval.sh:--ssh).gs://<bucket>/<run-name>/vbench_results(handles SSH credential passthrough without requiring GPU VM GCS service account scopes).benchmarks/vbench/gpu_eval_utils.py:Workflow
How to Test
1. TPU Generation
Direct on TPU or remote via SSH:
2. GPU Evaluation
Direct on GPU or remote via SSH:
3. Python Helper Verification