Fix TuiMonitor when using SimpleRestartingEventManager#3846
Open
Ollrogge wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As discussed in #3154,
TuiMonitorcan show an empty UI when used with restarting event managers.The issue is that
TuiMonitorstarts its rendering thread during construction. Restarting managers such asSimpleRestartingEventManagerand the LLMP restarting manager used byLauncherfork after the monitor has been constructed. Afterfork, only the calling thread exists in the child process, so the broker child receives and updates fuzzing stats but the TUI rendering thread doesn't exist.This PR fixes the issue by starting the TUI rendering thread lazily on the first
displaycall instead of during monitor construction. This ensures the rendering thread is created in the broker process, where monitor updates are applied.Checklist
./scripts/precommit.shand addressed all comments