Skip to content

Drop support for Tor v2 hidden services - #2296

Merged
t-bast merged 2 commits into
ACINQ:masterfrom
rorp:drop_tor_v2_services
Jun 6, 2022
Merged

t-bast merged 2 commits into
ACINQ:masterfrom
rorp:drop_tor_v2_services

Conversation

@rorp

@rorp rorp commented Jun 1, 2022

Copy link
Copy Markdown
Contributor

Inspired by #2234

@codecov-commenter

codecov-commenter commented Jun 1, 2022 •

Copy link
Copy Markdown

Codecov Report

Merging #2296 (52f8182) into master (9610fe3) will increase coverage by 0.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #2296      +/-   ##
==========================================
+ Coverage   84.29%   84.35%   +0.05%     
==========================================
  Files         194      194              
  Lines       14428    14419       -9     
  Branches      599      570      -29     
==========================================
+ Hits        12162    12163       +1     
+ Misses       2266     2256      -10     
Impacted Files Coverage Δ
...ir-core/src/main/scala/fr/acinq/eclair/Setup.scala 79.44% <ø> (+0.43%) ⬆️
...scala/fr/acinq/eclair/tor/TorProtocolHandler.scala 93.00% <100.00%> (+1.33%) ⬆️
...in/scala/fr/acinq/eclair/channel/fsm/Channel.scala 88.39% <0.00%> (+0.11%) ⬆️
...main/scala/fr/acinq/eclair/io/PeerConnection.scala 85.23% <0.00%> (+0.36%) ⬆️
...cala/fr/acinq/eclair/payment/relay/NodeRelay.scala 97.56% <0.00%> (+1.62%) ⬆️
.../acinq/eclair/blockchain/bitcoind/ZmqWatcher.scala 88.13% <0.00%> (+2.54%) ⬆️

@t-bast t-bast left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@t-bast
t-bast merged commit 47c5b95 into ACINQ:master Jun 6, 2022
@rorp
rorp deleted the drop_tor_v2_services branch June 16, 2022 16:30
@t-bast t-bast mentioned this pull request Jul 26, 2022
3 tasks done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants