Added implementation for super Path endpoints - #195
Merged
Conversation
Introduce new REST endpoints for accessing submodel descriptors, submodels, and submodel elements via AAS identifiers. Update controllers, handlers, services, and DTOs to support these routes. Add validation to ensure submodels belong to the specified AAS. Extend unit and integration tests, dependency injection, and test definitions (.bru) for the new functionality. Improves API discoverability and AAS API conformance.
…RepositoryService
Centralize submodel query logic by introducing SubmodelQueryOptions for Level and Extent parameters. Add explicit validation for submodel ownership via ValidateSubmodelBelongsToAasAsync. Update handlers, services, unit tests, and .bru API definitions to use the new approach. Remove obsolete helpers and improve code clarity and maintainability.
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
- Updated the submodel identifier parameter in "Get Submodel by submodelId and aaslId.bru" to use a custom submodel identifier. - Added query parameters for level and extent in "Get Submodel-element by idshort and aasID.bru". - Introduced query parameters for limit and cursor in "Get Submodel-elements by aasID.bru".
- Implemented new API endpoints for retrieving file attachments by idShortPath and aasId. - Updated existing endpoints to include new query parameters for level and extent. - Added unit tests to validate the new functionality and ensure proper error handling.
mm-hsh
marked this pull request as ready for review
August 7, 2026 10:55
…ier in GetResourceByIdAsync calls
Replaced multiple parameters with GetShellsByAssetIdsRequest in controller, handler, and interface for improved maintainability. Updated method calls and logic to use the new request object. Applied null-safe access patterns to other handler methods and cleaned up unused using directives.
…o use GetShellsByAssetIdsRequest object
Added detailed logging for resource fetches, including decoded AAS and Submodel IDs. Updated LogRequestStart to log differently for "shell descriptors" by omitting the AAS Identifier, while other resources include it.
mm-kgi
reviewed
Aug 11, 2026
Changed submodel identifier matching from case-insensitive (OrdinalIgnoreCase) to case-sensitive (Ordinal) in ValidateSubmodelBelongsToAasAsync. Submodel IDs must now match exactly, including case.
mm-asha
reviewed
Aug 13, 2026
mm-asha
reviewed
Aug 13, 2026
mm-asha
reviewed
Aug 13, 2026
mm-asha
reviewed
Aug 13, 2026
mm-asha
previously approved these changes
Aug 13, 2026
…unused services and improve code clarity
… improve parameter handling
…ryOptions for improved parameter handling
…for improved parameter handling
…ng and simplify object initialization
mm-omdi
marked this pull request as draft
August 17, 2026 06:52
…date related tests for consistency
…query options handling and ensure consistent formatting
…ions for improved parameter handling
|
Test & Coverage ReportTest Results Summary
Code CoverageUnit Tests Coverage
Minimum allowed line rate is Module Tests Coverage
|
mm-omdi
marked this pull request as ready for review
August 17, 2026 09:32
mm-asha
approved these changes
Aug 18, 2026
mm-kgi
approved these changes
Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several new API endpoints for handling submodel descriptors in the AAS Registry and Repository, updates test coverage for these endpoints, and makes minor improvements to variable and sequence management in the API collection. The main changes are the addition of endpoints to retrieve submodel descriptors by AAS ID and submodel ID, as well as comprehensive tests for these new features.
New API Endpoints for Submodel Descriptors:
Get Submodel Descriptors by aasIdandGet Submodel Descriptor by submodelId and aasIdendpoints to the AAS Registry collection, enabling retrieval of all or specific submodel descriptors for a given AAS (Get Submodel Descriptors by aasId.bru,Get Submodel Descriptor by submodelId and aasId.bru).Get Submodel by submodelId and aaslId.bru,Get Submodel-element by idshort and aasID.bru,Get Submodel-elements by aasID.bru).Test Coverage Improvements:
Enhanced
ShellDescriptorControllerTeststo cover the new endpoints, including tests for retrieving all submodel descriptors by AAS ID, fetching a specific submodel descriptor, handling missing submodels (404), and case-insensitive submodel ID matching.Variable and Environment Updates:
Added new variables for submodel identifiers for Product2 and Product3 and updated the pre-request script to include these variables in the environment (
collection.bru).Added a new environment configuration for
DataEngineBaseUrlin the local network environment (local-net.bru).Minor Improvements:
Get All ShellDescriptorsrequest.These changes collectively improve the API's capability to manage and retrieve submodel descriptors and enhance test reliability for these features.