fix: plumb the estimated flag end to end (#29) - #30
Merged
Conversation
OnBoundaryCallback gains a 6th param `estimated: bool`; WordBoundary carries the field; tts_set_on_boundary3 now reports the real value. - floravox: forwards floravox-core WordTiming.estimated (true on unpatched voices, false on duration-tensor-measured ones) - sherpa-onnx: true (150-wpm estimates) - cloud: false (provider timings track the delivered audio) - system/default estimator: true - v1/v2 C-ABI callbacks unchanged; v3 (tts_set_on_boundary3) was the hardcoded-0 lie this removes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fixes #29 —
tts_set_on_boundary3'sestimatedargument was hardcoded0because the flag didn't exist at the trait layer.OnBoundaryCallbackis now(word, start, end, char_offset, char_len, estimated)andWordBoundarycarries the fieldtts_set_on_boundary3passes the real value;tts_set_on_boundary/boundary2signatures unchangedWordTiming.estimated(the measured/unpatched distinction), sherpa-onnx =true(wpm estimates), cloud =false(provider timings track the audio), default estimator =trueSAPI can now badge "measured timings" voices truthfully and gate rescaling on the flag.
Breaking
OnBoundaryCallbacksignature change — all engines, examples, and tests updated in-tree.Test plan
-D warningson the full feature setcargo testgreen (system,cloud / sherpaonnx / floravox combinations)