BUILD: Move owid-rust to the key selection fix at 8aa5eee8 - #36
Merged
Conversation
SWAN-community/owid-rust#6, merged on 5 September 2026, sends the OWID's own date when fetching the creator's public key, holds fetched keys per request URL with the cache bounded at 1024 entries, and times requests out after 10 seconds. The 51Degrees fork fast forwarded to the same commit. fodid copies the source in without the fetch and endpoints features, so nothing shipped in the crate changes behaviour; the copy notice now records 8aa5eee8 and the source matches the other 51Did clients. cargo test --workspace, cargo test -p fodid --all-features, cargo fmt --check, cargo clippy -D warnings and cargo doc all clean.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Moves the
owid-rustsubmodule from 86181da2 to 8aa5eee8, the head of the 51Degrees fork after it took SWAN-community/owid-rust main (the fork fast forwarded, so the commit is the same one).Why
On 4 September 2026 the OWID ports were found to select a creator's signing key by the moment the key was generated rather than by the start of its period. The 51Degrees cloud writes thirteen weeks of keys in one run, so an identifier dated 4 September selected the key starting 7 September and genuine identifiers were reported as forged. The rule was corrected in the OWID specification (SWAN-community/owid#7) and in every port on 5 September 2026. The Rust fix is SWAN-community/owid-rust#6: the key fetch sends the OWID's own date, keys are held per request URL with the cache bounded at 1024 entries, requests time out after 10 seconds, and the stand in creator in the tests answers undated and future dates as the cloud does.
fodidcopies the OWID source in throughci/copy-owid-source.ps1and does not compile thefetchorendpointsfeatures, so nothing that ships in thefodidcrate changes behaviour. The bump keeps the copied source, and the commit the copy notice records, in step with the other 51Did clients, and any consumer that enablesfetchgets the corrected key selection.Verification
ci/copy-owid-source.ps1thencargo test --workspace: every suite passed (largest suite 19 tests), no failures.cargo test -p fodid --all-features: 24, 38 and 19 tests passed across the crate's suites, 1 ignored, no failures.cargo fmt --all -- --check,cargo clippy --workspace --all-targets -- -D warningsandcargo doc --workspace --no-depsall clean, matching the pull request workflow.Notes
fodid/src/owidstays ignored by git, so the only change in this pull request is the submodule pointer.Produced with AI assistance and checked against the outputs above.