FEAT: Emit performance results JSON from the examples - #35
Open
oleksandrlazarenko-pi wants to merge 2 commits into
Open
FEAT: Emit performance results JSON from the examples#35oleksandrlazarenko-pi wants to merge 2 commits into
oleksandrlazarenko-pi wants to merge 2 commits into
Conversation
Adds a PerformanceResults model to examples-shared, used by both dd-onprem-performance and ipi-onprem-performance, so the two emit an identical structure. The examples take --json-output and write the results themselves, replacing the throughput figures CI used to regex out of their printed output.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of 51Degrees/common-ci#215, which was raised from this repository. Adds examples_shared::PerformanceResults as the one definition of the graph schema and has both on-premise performance examples write it. Merge this BEFORE the common-ci PR: the printed report is unchanged, so the current adapter keeps working, but the new adapter requires these examples.