Release fodid 4.5.4 so the match key constants reach crates.io - #31
Open
jwrosewell wants to merge 1 commit into
Open
Release fodid 4.5.4 so the match key constants reach crates.io#31jwrosewell wants to merge 1 commit into
jwrosewell wants to merge 1 commit into
Conversation
The match key rename landed in 30 but the crate version did not move, and ci/publish-crates.sh skips any version already on crates.io, so the publish run on that merge finished green having published nothing. crates.io still serves 4.5.3, which carries the old constant names only. This bumps the fodid crate so the next publish has something to release. fiftyone-fodid-cloud needs no change, because its dependency on fodid is written as 4.5.3, which Cargo reads as caret 4.5.3 and which 4.5.4 satisfies.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The match key rename landed in 30, so
MATCH_KEY_OFFSETandMATCH_KEY_LENGTHare onmain. Customers cannot see them, because the crate version did not move.ci/publish-crates.shasks crates.io whether a version is already there and skips it if so. Thefodidcrate is still4.5.3and 4.5.3 is already published, so the publish run triggered by that merge, 33626340484, finished green having released nothing. crates.io still serves 4.5.3, which carries the old constant names only.What changed
One line.
fodid/Cargo.tomlmoves from 4.5.3 to 4.5.4, so the next publish has something to release.fiftyone-fodid-cloudneeds no change. Its dependency readsfodid = { version = "4.5.3", path = "../fodid" }, and Cargo treats a bare version as a caret requirement, so 4.5.4 satisfies it.What this releases
The finished match key vocabulary.
MATCH_KEY_OFFSETandMATCH_KEY_LENGTHbecome the real constants, withHASH_OFFSETandHASH_LENGTHkept as#[deprecated]aliases so nothing breaks for anyone already using them.HEADER_LENGTHandPAYLOAD_LENGTHkeep their names.The same rename is now merged in the .NET, Java, Python, PHP and Node ports, so the vocabulary is consistent across all six. .NET is published as
FiftyOne.Did4.5.88.Verification
Merging this is what runs the publish, so the proof is the run itself rather than anything that can be shown here. Worth watching that the publish job releases
fodidrather than skipping it again, and thatverify-publishedthen builds the examples against the released crate.Produced with AI assistance under James Rosewell's direction and needs human review.