Let cargo publish carry the copied OWID source - #29
Merged
Conversation
The first publish of fodid 4.5.3 stopped with cargo refusing thirteen files under fodid/src/owid that were not committed to git. They never will be, because ci/copy-owid-source.ps1 copies them from the owid-rust submodule before every build and git ignores the copy on purpose, so the publish call now passes --allow-dirty. The workflow starts from a clean checkout, so that copy is the only thing the flag lets through, and a publish dry run of fodid packages and verifies with it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The push to main from #28 ran the publish workflow, which stopped at fodid with cargo refusing thirteen files under
fodid/src/owidas not committed to git (run https://github.com/51Degrees/rust/actions/runs/33408926369). Nothing was published, crates.io still holds 4.5.2 for both crates.Those files are the OWID source that
ci/copy-owid-source.ps1copies from theowid-rustsubmodule before every build. The copy is git ignored on purpose so the submodule stays the only copy in the repository, and thefodidmanifest lists the directory inincludeso the package carries it. Cargo's uncommitted files check does not know that, so the publish call inci/publish-crates.shnow passes--allow-dirty, with a comment saying why. The workflow starts from a clean checkout, so the copy is the only thing the flag lets through.Proof: locally,
cargo publish --dry-run -p fodidrefuses with the same message, andcargo publish --dry-run -p fodid --allow-dirtypackages and verifies the crate. Merging this pushes to main and the workflow publishes fodid 4.5.3 and fiftyone-fodid-cloud 4.5.3.Produced with AI assistance under James Rosewell's direction and needs human review.