Move owid-js to the commit that refuses redirects when fetching a key - #191
Merged
Conversation
…g a key The 51Degrees fork of owid-js now carries SWAN-community/owid-js#12, which stops fetch following a redirect from a creator domain, so a creator whose domain answered 302 could no longer have some other host's key trusted as its own, nor have the publisher's fetchHeaders credential delivered there. The pin moves from 9aeb0d24 to 148763cb, the fork's main after the sync. fiftyone.pipeline.did tests: 139 passed, 2 skipped.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the owid-js pin from 9aeb0d24 to 148763cb, the 51Degrees fork main after syncing SWAN-community/owid-js#12, which stops fetch following a redirect from a creator domain. Without it a creator whose domain answered 302 could have some other host's key trusted as its own, and the publisher's fetchHeaders credential would have travelled there too. Package tests: 139 passed, 2 skipped. Produced with AI assistance and needs human review.