Skip to content

fix(opencode): Accept nested provider model paths #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
4ndreello merged 1 commit into from
Sep 19, 2026
Merged

fix(opencode): Accept nested provider model paths #90

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/open/launchers/opencode.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ export function buildInlineConfig(
});
}

const MODEL_SHAPE = /^[^/\s]+\/[^/\s]+$/;
const MODEL_SHAPE = /^[^/\s]+\/[^/\s]+(?:\/[^/\s]+)*$/;

export function buildArgs(
role: Role,
Expand Down
14 changes: 14 additions & 0 deletions tests/open-opencode.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -264,6 +264,20 @@ describe("buildArgs", () => {
expect(() => buildArgs("general", { model: bad }, [])).toThrow(/must be provider\/model/);
}
});

it.each([
["an empty middle segment", "a//b"],
["a trailing slash after nesting", "a/b/"],
["whitespace after nesting", "a/b c/d"],
] as const)("rejects a model with %s before spawn", (_name, model) => {
expect(() => buildArgs("general", { model }, [])).toThrow(/must be provider\/model/);
});

it("accepts provider models with nested model paths", () => {
for (const model of ["openrouter/meta/muse-spark-1.3-contributor", "a/b/c/d"]) {
expect(() => buildArgs("general", { model }, [])).not.toThrow();
}
});
});

describe("opencode theme", () => {
Expand Down
Loading