feat(plugin): Gate PR visuals and source PR prompts from skills - #122
Merged
Merged
Conversation
PR descriptions had no guidance on screenshots, GIFs or diagrams, so agents either skipped them where a reviewer needed one or could add them everywhere. Add a Visual Evidence section to the pr-writer partial that defaults to none, maps change types to the evidence that fits, and gives a recipe for hosting images on an orphan pr-assets branch, since gh cannot upload attachments. Co-Authored-By: Claude <noreply@anthropic.com>
4ndreello
marked this pull request as ready for review
September 25, 2026 01:43
The commit and pr-writer partials were hand-vendored copies of the global skills, so every edit had to land twice. Move the skills into skills/ as the single source and have copy-plugin.mjs render the two general-agent sections from them, applying the adaptations that swap references to skills the prompt cannot load. The build fails when an adaptation stops matching, so a skill edit cannot silently ship a stale or broken prompt. Co-Authored-By: Claude <noreply@anthropic.com>
4ndreello
changed the title
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a Visual Evidence section to the pr-writer skill, and makes
skills/commitandskills/pr-writerthe single source for the commit and PR sections of the general agent.Until now the PR prompt said nothing about visuals. The worry with adding one is overuse, so the section defaults to none and only allows a visual when a reviewer would otherwise need to check out the branch to see the change. A table maps change types to evidence: screenshots for UI, a short GIF for interaction, real fenced output for CLI/TUI, Mermaid for a new multi-component flow, and nothing for refactors, config, deps, internal fixes or tests. Captures must come from the running app.
ghcannot upload attachments, so the section includes a recipe that pushes images to an orphanpr-assetsbranch through a temporary worktree and links them withblob/...?raw=true, which also renders on private repos. The recipe was run twice against a local bare remote: the first run created the orphan branch, the second appended to it, and the working branch stayed untouched. It has not been exercised against GitHub yet. Video stays out of reach for the agent: it hands back the file path and says the user has to drag it in.The
commitandpr-writerpartials were hand-vendored copies of the global skills, so this change would have had to land twice. They now live inskills/, andscripts/copy-plugin.mjsrenders the two sections from them throughSKILL_PARTIALS, applying the adaptations that swapsentry-skills:commit,create-branchand the Claude co-author line. The partial is still needed because non-claude harnesses get the role prompt prepended and cannot load skills. The build fails if an adaptation stops matching or a skill reference survives, checked by editing the skill and watching the build throw. Apart from the source header, the Visual Evidence section and thegh apiexamples merging into one code block (as they already were in the skill), the generatedgeneral.mdis unchanged.general.mdis now 15.5KB of its 16KB budget, which leaves little room for growth in that role.