ref(config): Remove the setup profile system - #114
Merged
Merged
Conversation
Co-Authored-By: Codex <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Why
Profiles overlaid a named snapshot on top of the base config, and the result drifted:
doctorreported one setup while launches resolved another. Rather than patch the overlay, this removes it. There is one setup again, the top-level config, so whatdoctorprints is whatrunandopenuse.What changes
codedeck profilecommand (src/cli/commands/profile.ts).--profilefromrun,openandsetup.src/config/config.ts(resolveEffectiveConfig,ProfileSnapshot, name parsing, listing) and the profile branch ofresolveSetupTarget/buildSetupPlaninsrc/config/setup.ts.doctorprints plainRoleswith noProfilesection, anddoctor --jsonno longer carriesactiveProfile/activeProfileError.Existing
profiles/activeProfilekeys in a user config are left alone: nothing reads them, and every setup path (CLI, wizard, web) preserves them on save. No config data is deleted.Spec and validation:
.specs/features/remove-profiles/.Verification
npx tsc --noEmit -p .passes.npx vitest run tests/doctor-roles.test.ts tests/open-action.test.ts tests/run-role.test.ts tests/setup-cli-contract.test.ts tests/setup-plan.test.ts tests/setup-web.test.ts tests/setup-wizard.test.ts: 7 files, 197 tests passed.run.tsanddoctor.tsfails the two new tests (2/2 killed). Reverted, they pass again.codedeck profile listexits withunknown command 'profile',run --profile xwithunknown option '--profile', anddoctorshowsRolesfrom the top-level bindings.