Fix htslib include path for HTSLIB=system builds - #119
Open
Maarten-vd-Sande wants to merge 2 commits into
Open
Maarten-vd-Sande wants to merge 2 commits into
Maarten-vd-Sande wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HTSLIB=systemwas broken, turns out the include path was wrong, so it always failed to build against a system htslib and silently fell back to building its own. Also, newer htslib versions need their submodules pulled in too, which the build script wasn't doing. Fixed both soHTSLIB=systemactually works now.DISCLAIMER: This was vibe-coded by claude, but I tested it and seems to work as expected. I had some issues with CRAM 3.1 spec, and that's now resolved