fix: preserve macOS Ctrl+5 prompt jump - #1137
Open
1jehuang wants to merge 1 commit into
Open
Conversation
Greptile SummaryThis change preserves Ctrl+5 on macOS so users can jump to the fifth-most-recent prompt, without changing Ctrl+[ or the Ctrl+Esc compatibility fallback. Direct normalization checks and application-level prompt-jump tests confirmed that the intended key paths continue to work. Confidence Score: 5/5Safe to merge: the changed key-normalization behavior preserves Ctrl+5 and retains the existing Ctrl+[ fallback. No defects were found. Executable before-and-after normalization checks and focused application-level tests exercised the affected Ctrl+5, Ctrl+[, and Ctrl+Esc paths successfully. Files Needing Attention: No files need further attention.
What T-Rex did
Reviews (1): Last reviewed commit: "fix: preserve macOS Ctrl+5 prompt jump (..." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ctrl+5into the legacyCtrl+]aliasEsctoCtrl+[fallbackVerification
cargo test -p jcode-tui --lib prompt_jump_ctrl_digit(2 passed)cargo check -p jcode-tuiThe affected rewrite is macOS-only, so final platform behavior remains subject to macOS CI/review validation.
Fixes #1131
--- — Jcode agent (automated triage), on behalf of @1jehuang