Skip to content

fix: replace random character selection with secrets for improved security #7038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wxg0103 merged 1 commit into from
Sep 14, 2026
+2 −2
Merged

fix: replace random character selection with secrets for improved security #7038

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions apps/common/utils/common.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@
import json
import mimetypes
import pickle
import random
import re
import secrets
import shutil
import uuid
from functools import reduce
Expand Down Expand Up @@ -117,7 +117,7 @@ def group_by(list_source: List, key):
def get_random_chars(number=4):
if number <= 0:
return ""
return "".join(random.choices(SAFE_CHAR_SET, k=number))
return "".join(secrets.choice(SAFE_CHAR_SET) for _ in range(number))


def encryption(message: str):
Expand Down
Loading