Skip to content

fix: MaxKB Security Report: Chat-face chat_message lets another visitor write into an existing session (#6825) #6853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shaohuzhang1 merged 1 commit into from
Sep 1, 2026
Merged

fix: MaxKB Security Report: Chat-face chat_message lets another visitor write into an existing session (#6825) #6853

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 10 additions & 8 deletions apps/chat/serializers/chat.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -297,8 +297,10 @@ def is_valid_application_workflow(self, *, raise_exception=False):

def is_valid_chat_id(self, chat_info: ChatInfo):
if self.data.get('application_id') is not None and self.data.get('application_id') != str(
chat_info.application_id) and self.data.get('chat_user_id') is not None and self.data.get(
'chat_user_id') != str(chat_info.chat_user_id):
chat_info.application_id):
raise ChatException(500, _("Conversation does not exist"))
if self.data.get('chat_user_id') is not None and self.data.get('chat_user_id') != str(
chat_info.chat_user_id):
raise ChatException(500, _("Conversation does not exist"))

def is_valid_intraday_access_num(self):
Expand Down Expand Up @@ -491,11 +493,11 @@ def re_open_chat(self, chat_id: str):
if application_version is None:
raise ChatException(500, _("The application has not been published. Please use it after publishing."))
if application.type == ApplicationTypeChoices.SIMPLE:
return self.re_open_chat_simple(chat_id, application)
return self.re_open_chat_simple(chat_id, application, chat)
else:
return self.re_open_chat_work_flow(chat_id, application)
return self.re_open_chat_work_flow(chat_id, application, chat)

def re_open_chat_simple(self, chat_id, application):
def re_open_chat_simple(self, chat_id, application: Application, chat: Chat):
if self.data.get('debug'):
# 数据集id列表
knowledge_id_list = [str(row.target_id) for row in
Expand All @@ -512,7 +514,7 @@ def re_open_chat_simple(self, chat_id, application):
QuerySet(Document).filter(
knowledge_id__in=knowledge_id_list,
is_active=False)]
chat_info = ChatInfo(chat_id, self.data.get('chat_user_id'), self.data.get('chat_user_type'),
chat_info = ChatInfo(chat_id, chat.chat_user_id, str(chat.chat_user_type),
self.data.get('ip_address'),
self.data.get('source'), knowledge_id_list,
exclude_document_id_list, application.id)
Expand All @@ -522,8 +524,8 @@ def re_open_chat_simple(self, chat_id, application):
chat_info.chat_record_list.append(chat_record)
return chat_info

def re_open_chat_work_flow(self, chat_id, application):
chat_info = ChatInfo(chat_id, self.data.get('chat_user_id'), self.data.get('chat_user_type'),
def re_open_chat_work_flow(self, chat_id, application: Application, chat: Chat):
chat_info = ChatInfo(chat_id, chat.chat_user_id, str(chat.chat_user_type),
self.data.get('ip_address'),
self.data.get('source'), [], [],
application.id)
Expand Down
Loading