Skip to content

fix: avoid website SSL port conflicts on creation - #13720

Merged
ssongliu merged 1 commit into
1Panel-dev:dev-v2from
A-Words:fix/13682-website-port-conflict
Sep 7, 2026
Merged

fix: avoid website SSL port conflicts on creation#13720
ssongliu merged 1 commit into
1Panel-dev:dev-v2from
A-Words:fix/13682-website-port-conflict

Conversation

@A-Words

@A-Words A-Words commented Sep 5, 2026

Copy link
Copy Markdown
Contributor

What this PR does / why we need it?

Fixes #13682.

When a website already listens on a custom HTTPS port such as 8444, creating another HTTPS website on the same port could first generate a plain listen 8444 configuration. That conflicts with the existing listen 8444 ssl configuration and makes the creation fail.

Summary of your change

  • Apply the selected certificate and HTTPS listen configuration during the initial website configuration write.
  • Reuse the TLS port planning/configuration logic for both initial creation and later HTTPS updates.
  • Keep the website creation form's domain-level SSL selection and HTTPS state in sync.

Please indicate you've done the following:

  • Made sure tests are passing and test coverage is added if needed.
  • Made sure commit message follow the rule of Conventional Commits specification.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed.

@ssongliu
ssongliu merged commit eb6a8c7 into 1Panel-dev:dev-v2 Sep 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Website creation keeps failing due to conflicts

2 participants