Repository navigation
feat(sandbox): opt-in OCI runtime with enforceable cgroup quotas and real isolation CI - #27
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase 6: introduce an explicit Linux Docker/OCI Shell backend rather than claiming that per-process rlimits provide aggregate isolation.
shell_sandbox="docker"withsandbox_imagerequired and SHA256 digest-pinned, pre-pulled-only (--pull=never).--network=none,--ipc=none,--read-only,--cap-drop=ALL, no-new-privileges, unprivileged host UID/GID and private/tmp; only bind an explicitly selected workspace, reject system-root and ambiguous mount paths.--memory/--memory-swap,--cpus,--pids-limitconfiguration. Keep normal Wall-clock timeout and output caps.docker rm -fon success, timeout or cancellation prevents abandoned daemon-managed containers./sys/fs/cgroupmemory/pids limits, lack of network routes and workspace-only file access.Scope: only built-in async Shell; Docker daemon and host bind mounts are trusted components. Does not isolate other plugin handlers, provide a kernel proof, or imply production-grade multi-tenant security. Default
shell_sandbox="off"unchanged.