Repository navigation
feat(shell): optional fail-closed Linux bubblewrap filesystem/network sandbox - #24
Merged
Merged
Conversation
…l namespace smoke
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce an opt-in Linux
shell_sandbox="bubblewrap"backend for the registered async Shell skill. The default remainsofffor compatibility.--unshare-allisolates PID/network and other namespaces,--tmpfs /creates a fresh root, only system executable/library directories are read-only bound, host workspace is the only writable host mount,/tmpis private, environment is cleared./bin/sh -c <command>inside the namespace.AgentConfig.shell_sandbox/ CLI--shell-sandbox bubblewrap; previous no-HITL explicit opt-in behavior is unchanged.Limits: Not an arbitrary-plugin sandbox, not a kernel-hardening guarantee, not cgroup CPU/RAM quotas, and not protection against TOCTOU or secrets already present inside the mounted workspace. Real execution needs bwrap and Linux user namespace support; GH CI may skip the smoke on hosts without it.