Fix: preserve arguments with spaces during encryption/decryption#18
Open
12end wants to merge 1 commit into
Open
Fix: preserve arguments with spaces during encryption/decryption#1812end wants to merge 1 commit into
12end wants to merge 1 commit into
Conversation
The original implementation used strings.Join(args, " ") and strings.Split(output, " ") to serialize/deserialize arguments. This caused issues when arguments contained spaces, as they were incorrectly split into multiple arguments. The fix encodes each argument individually using base64, then joins them with a NULL separator (\x00). Base64 output only contains alphanumeric characters plus '+', '/', and '=', which cannot appear in the separator. This ensures arguments with spaces, tabs, newlines, or other special characters are preserved correctly. Also handle empty strings by encoding them as a single space before base64 encoding. Fixes #16 Co-authored-by: openhands <openhands@all-hands.dev>
12end
force-pushed
the
openhands/fix-arg-encoding-with-spaces-v2
branch
from
44576e5 to
6263536
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes issue #16: Arguments containing spaces were incorrectly split during the encryption/decryption cycle.
Problem
The original implementation used
strings.Join(args, " ")andstrings.Split(output, " ")to serialize/deserialize arguments. When arguments contained spaces (e.g.,--name "hello world"), they were incorrectly split into multiple argument after decryption.Solution
Instead of joining arguments with a space separator, each argument is now individually base64-encoded, then joined with a NULL separator (
\x00). This ensures:Changes
cargs.go: AddedencodeArgs()anddecodeArgs()helper functionscargs_test.go: Test cases covering various edge cases including spaces, empty strings, special characters, unicode, etc.Testing
All tests pass:
This PR was created by an AI agent (OpenHands) on behalf of the user.