fix: use JSON encoding for args to preserve spaces in values#17
Draft
12end wants to merge 1 commit into
Draft
Conversation
Fix issue #15: Arguments containing spaces were incorrectly split after encryption/decryption because the code used strings.Join/Split with space as delimiter. The fix uses JSON encoding (encodeArgsJSON/decodeArgsJSON) to serialize the args slice, which correctly handles: - Arguments with spaces (e.g., 'hello world') - Empty arguments - Arguments with special characters - Multiple consecutive spaces
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix issue #15: Arguments containing spaces were incorrectly split after encryption/decryption because the code used
strings.Join/strings.Splitwith space as delimiter.Problem
The original code in
cargs.goused:This caused arguments with internal spaces (e.g.,
--name "hello world") to be split incorrectly after decryption, resulting in the argument being broken into multiple arguments.Solution
Use JSON encoding (
json.Marshal/json.Unmarshal) to serialize the args slice instead of space-based join/split. This correctly handles:Changes
encodeArgsJSONanddecodeArgsJSONfunctions that use JSON serializationstrings.Join/strings.SplitTesting
All tests pass:
TestEncodeDecodeArgs- Tests base64 per-argument encodingTestEncodeDecodeArgsJSON- Tests JSON encoding (the actual implementation)TestEncodeDecodeEmptyArgs- Tests empty argument handlingTestEncodeDecodeEmptyArgsJSON- Tests JSON empty argument handlingCloses #15
@12end can click here to continue refining the PR