Skip to content

Fix expects abstract constraint validator test case #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
frankdekker merged 9 commits into from
Feb 12, 2026
Merged

Fix expects abstract constraint validator test case #38

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
f6e4c04
Make all class properties mock perform expectations
cardoso123inkt Feb 11, 2026
8567648
Make all class properties mock perform expectations
cardoso123inkt Feb 11, 2026
368be8f
Make all class properties mock perform expectations
cardoso123inkt Feb 11, 2026
37a5f82
Make all class properties mock perform expectations
cardoso123inkt Feb 11, 2026
326ebf7
Make all class properties mock perform expectations
cardoso123inkt Feb 11, 2026
1e7effa
Make all class properties mock perform expectations
cardoso123inkt Feb 11, 2026
472e881
Merge remote-tracking branch 'origin/fix-expects-abstract-constraint-…
cardoso123inkt Feb 11, 2026
2b48668
Make all class properties mock perform expectations
cardoso123inkt Feb 11, 2026
d884cf5
Make all class properties mock perform expectations
cardoso123inkt Feb 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 16 additions & 9 deletions src/Symfony/AbstractConstraintValidatorTestCase.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,14 +78,19 @@ protected function initRootForm(): Form
*/
protected function assertHandlesIncorrectConstraintType(mixed $value = null): void
{
$this->executionContext->expects(self::never())->method(self::anything());
$this->violationBuilder->expects(self::never())->method(self::anything());

$this->expectException(UnexpectedTypeException::class);
$this->validator->validate($value, $this->createMock(Constraint::class));
$this->validator->validate($value, static::createStub(Constraint::class));
Comment thread
frankdekker marked this conversation as resolved.
}

protected function expectNoViolations(): void
{
$this->executionContext->expects(static::never())->method('buildViolation');
$this->executionContext->expects(static::never())->method('addViolation');
$this->executionContext->expects(self::never())->method('buildViolation');
$this->executionContext->expects(self::never())->method('addViolation');

$this->violationBuilder->expects(self::never())->method(self::anything());
}

/**
Expand All @@ -96,7 +101,9 @@ protected function expectNoViolations(): void
*/
protected function expectViolation(string $message, array $parameters = []): void
{
$this->executionContext->expects(static::once())->method('addViolation')->with($message, $parameters);
$this->executionContext->expects(self::once())->method('addViolation')->with($message, $parameters);

$this->violationBuilder->expects(self::never())->method(self::anything());
}

/**
Expand All @@ -113,14 +120,14 @@ protected function expectViolationViaBuilder(
?string $atPath = null,
mixed $invalidValue = self::IGNORE_INVALID_VALUE
): void {
$this->executionContext->expects(static::once())->method('buildViolation')->with($message, $parameters)->willReturn($this->violationBuilder);
$this->executionContext->expects(self::once())->method('buildViolation')->with($message, $parameters)->willReturn($this->violationBuilder);
if ($atPath !== null) {
$this->violationBuilder->expects(static::once())->method('atPath')->with($atPath)->willReturnSelf();
$this->violationBuilder->expects(self::once())->method('atPath')->with($atPath)->willReturnSelf();
}
if ($invalidValue !== self::IGNORE_INVALID_VALUE) {
$this->violationBuilder->expects(static::once())->method('setInvalidValue')->with($invalidValue)->willReturnSelf();
$this->violationBuilder->expects(self::once())->method('setInvalidValue')->with($invalidValue)->willReturnSelf();
}
$this->violationBuilder->expects(static::once())->method('addViolation');
$this->violationBuilder->expects(self::once())->method('addViolation');
}

/**
Expand All @@ -145,7 +152,7 @@ protected function expectViolationViaBuilder(
*/
protected function expectBuildViolation(string $message, array $parameters = []): ConstraintViolationBuilderAssertion
{
$this->executionContext->expects(static::once())->method('buildViolation')->with($message, $parameters)->willReturn($this->violationBuilder);
$this->executionContext->expects(self::once())->method('buildViolation')->with($message, $parameters)->willReturn($this->violationBuilder);

return new ConstraintViolationBuilderAssertion($this->violationBuilder);
}
Expand Down
Loading