feat: FlexCrop clip edges in composition pixels - #123
Open
J160KU wants to merge 7 commits into
Open
Conversation
Add Kdenlive-style Crop Left/Right/Top/Bottom sliders and edit_item transform.crop so users and the in-app agent can trim clip edges with 1px precision. Co-authored-by: Cursor <cursoragent@cursor.com>
Keep a small J160KU credit at the README footer without a banner. Co-authored-by: Cursor <cursoragent@cursor.com>
Add an Unreleased changelog entry, a Clip crop section at the top of both READMEs, and refresh the agent tool catalog so edit_item transform.crop is documented. Co-authored-by: Cursor <cursoragent@cursor.com>
Keep the FlexCrop PR from replacing OpenChatCut's README; clip crop notes stay in FLEXCROP.md. Co-authored-by: Cursor <cursoragent@cursor.com>
Keep the FlexCrop PR from replacing OpenChatCut's Chinese README; clip crop notes stay in FLEXCROP.md. Co-authored-by: Cursor <cursoragent@cursor.com>
The preview wrapper uses the stage content box and one composition scale so Remotion does not letterbox on Y under the overlay; rotation stays centered. Co-authored-by: Cursor <cursoragent@cursor.com>
Inspector open/close recenters the preview canvas; overlay-relative pointer math looked like spurious drags. Track clientX/clientY and map through the live canvas rect on each move. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
edit_itemtransform.crop/transform.flexCropuse composition pixels (left/right 0…canvas width, top/bottom 0…canvas height). Storage stays a 0–1 canvas fraction.transform.crop: nullclears crop.CHANGELOG.md[Unreleased], a Clip crop section at the top ofREADME.md/README_ZH.md, and the generated agent tool catalog.Replaces #122 (same commits; branch renamed
j160ku/clip-crop-inspector→j160ku/flexcrop).Test plan
pxand the preview checkerboard shows through cropped edges.edit_itemwithtransform.crop: { left: 240 }(pixels, not percent);transform.crop: nullclears.tsx src/editor/clipCrop.verify.ts,tsx src/agent/tools/edit-item-generic.verify.ts,tsx src/components/inspector/inspector-controls.verify.tsMade with Cursor