fix(qwen): preserve compact logits indices across graph reuse - #426
Merged
0xShug0 merged 1 commit intoSep 3, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix compact-logit row-index tensors in the shared Qwen causal decode runtime being overwritten when a cached prefill graph is reused.
The compact readback path creates an I32 tensor consumed by
ggml_get_rows. It is populated by the host after graph allocation, but it was not marked as a graph input. The allocator could therefore alias its storage with an intermediate tensor. A first request could succeed while leaving corrupted indices for the next execution, which was observed as an illegal CUDA memory access on the second request.Changes
Validation
audiocpp_clibuild: passedengine_corerebuild: passedengine_corebuild for SM 86: passedgit diff --check: passedThis is isolated from the MiraTTS model work and changes only the shared Qwen runtime lifecycle for configurations using
logits_readback_token_ids.