webui: complete the shipped translations - #421
Closed
CryptVenture wants to merge 1 commit into
Closed
Conversation
Seven keys were missing from all four translation files, so the localised UI
was visibly half-English:
- file.clear and file.preview sit on every file input in the app.
- task.midi labelled MuScriptor in English for every non-English user.
- request.autoDuration, request.rewriteCaption, request.rewritingCaption and
voice.configured were likewise untranslated.
Also fills in param.* coverage, which stood at roughly ten keys per language
out of nearly three hundred. Chinese gains 111 keys back-filled from the
Chinese label, info and placeholder text already in model_params.json, which
the build discards because catalog.ts strips Han characters -- so that wording
was in the repo but unreachable even for Chinese users. Italian, Polish and
Russian gain 39 each, limited to entries whose meaning is unambiguous from the
English label and the option's own documentation.
The two studio.subtitle.* keys are translated here; their English source keys
are added by the string-fix change, and until that lands these entries are
simply unused.
Only webui/native/lang/*.json changes.
Validation:
python3 -m json.tool on each file
Every non-param key checked against the English table in i18n.ts.
CryptVenture
force-pushed
the
pr/webui-translations-only
branch
from
September 3, 2026 01:43
00f5c35 to
0af0ace
Compare
Contributor
Author
|
Closing for now to stay inside the 3-concurrent-PR policy (see the discussion on #422). Nothing is wrong with the change and CI is green on it; I will reopen it as review slots free. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces #375, reduced to translations as requested: this PR touches
webui/native/lang/*.jsonand nothing else — no specs, no catalog, no UI behaviour, no generated bundle.The problem
Seven keys were missing from all four translation files, so the localised UI was visibly half-English:
file.clearandfile.previewsit on every file input in the apptask.midilabelled MuScriptor in English for every non-English userrequest.autoDuration,request.rewriteCaption,request.rewritingCaption,voice.configuredparam.*coverage stood at roughly ten keys per language out of nearly three hundred, so the parameter panels were English for everyone.The change
lang_zh.jsonlang_it.jsonlang_pl.jsonlang_ru.jsonChinese gains 111 keys back-filled from the Chinese
label,infoandplaceholdertext already inmodel_params.json, which the build discards becausecatalog.tsstrips Han characters — that wording was in the repository but unreachable even for Chinese users. Italian, Polish and Russian gain 39 each, limited to entries whose meaning is unambiguous from the English label and the option's own documentation.The two
studio.subtitle.*keys are translated here; their English source keys are added by the sibling string-fix PR, and until that lands these entries are simply unused.Validation
python3 -m json.tool webui/native/lang/lang_{zh,it,pl,ru}.json # all parseEvery non-
param.*key was checked against the English table insrc/lib/i18n.ts: the only keys not present there are the twostudio.subtitle.*above.Scope
Four JSON files. No code, spec, catalog or bundle change.