webui: give the parameter controls English labels and accurate help text - #420
Closed
CryptVenture wants to merge 1 commit into
Closed
webui: give the parameter controls English labels and accurate help text#420CryptVenture wants to merge 1 commit into
CryptVenture wants to merge 1 commit into
Conversation
42 controls carried a Chinese label with no label_en, so the English UI showed the raw option key, and several info strings described behaviour the engine does not have. This change is text only: no name, type, default, range or choice list moves. The file's own comment claimed that only user-modified values are sent. That has never been true in this UI -- every control with a default is sent on every request -- so the comment now documents the real behaviour, including that omitting a default is how a control says "unset", because the option parser skips empty values. Validation: python3 -m json.tool webui/configs/model_params.json python3 tools/check_loader_catalog_sync.py # in sync
CryptVenture
force-pushed
the
pr/params-english-labels
branch
from
September 3, 2026 01:42
83f75f0 to
bd68114
Compare
Contributor
Author
|
Closing for now to stay inside the 3-concurrent-PR policy (see the discussion on #422). Nothing is wrong with the change and CI is green on it; I will reopen it as review slots free. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split out of #374 as requested: label and help text only. The dead controls, the default overrides, the range fixes and the missing groups are separate PRs.
The change
label_en/info_en/placeholder_en. They carried a Chinese label with no English counterpart, so the English UI fell back to printing the raw option key.infostrings described behaviour the engine does not have and now describe what it does._commentclaimed only user-modified values are sent. That has never been true in this UI — every control with a default is sent on every request — so the comment now documents the real behaviour, including that omitting a default is how a control says unset (the option parser skips empty values).No
name,type,default,minimum,maximum,steporchoicesvalue changes here, so no request shape changes.Validation
Scope
One data file, 43 lines. No behaviour change of any kind. The generated bundle is deliberately excluded —
catalog.tsinlines this file at frontend build time and the bundle is not byte-reproducible, so regenerating it in each PR of this split would make the PRs conflict; happy to send one bundle-regeneration PR once the series lands.