webui: expose the quality-critical options existing groups were missing - #419
Closed
CryptVenture wants to merge 1 commit into
Closed
webui: expose the quality-critical options existing groups were missing#419CryptVenture wants to merge 1 commit into
CryptVenture wants to merge 1 commit into
Conversation
Twenty groups already existed but left out options their families read, so the
controls that decide output quality were reachable only through the JSON
fallback box.
- omnivoice: t_shift, class_temperature, position_temperature,
layer_penalty_factor, denoise, preprocess_prompt, postprocess_output and
the audio/text chunking knobs (session.cpp:100-116, loader.cpp:34).
- irodori_tts: its seven guidance knobs plus duration bounds, no_ref,
trim_tail and the instruction field (session.cpp:451-454 and the guidance
block).
- index_tts2: the whole sampling block -- do_sample, temperature, top_p,
top_k, repetition_penalty, num_beams, length_penalty.
- chatterbox: min_p, its actual truncation filter, alongside top_p, whose
default is a documented no-op, and s3gen_cfg_rate.
- qwen3_tts: the sub-talker block and x_vector_only_mode.
- minimax_music3: ensemble takes and the flow uncond/hop controls.
- seed_vc: f0_condition, auto_f0_adjust and semitone_shift, without which
the SVC entry cannot do what SVC is for.
- voxcpm1/voxcpm2: retry_badcase controls; heartmula: chunking; neutts,
vibevoice, stable_audio, ace_step, minimax_h3 and the four firered-audio
groups: the sampling or negative-prompt options each reads.
Every name was checked against the family's sources. Two controls that the
original change had for omnivoice -- reference_max_seconds and
reference_pad_ms -- are left out: nothing in the tree reads them.
Validation:
python3 -m json.tool webui/configs/model_params.json
python3 tools/check_loader_catalog_sync.py # in sync
CryptVenture
force-pushed
the
pr/params-missing-controls
branch
from
September 3, 2026 01:42
23a84d2 to
1ca1cc8
Compare
Contributor
Author
|
Closing for now to stay inside the 3-concurrent-PR policy (see the discussion on #422). Nothing is wrong with the change and CI is green on it; I will reopen it as review slots free. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split out of #374 as requested: options missing from groups that already exist. The new analysis groups, the new TTS groups, the dead controls, the default overrides and the range fixes are separate PRs.
The problem
Twenty groups existed but left out options their families read — including the ones that decide output quality. They were reachable only by hand-writing JSON into the fallback box.
What is added
omnivoicet_shift,class_temperature,position_temperature,layer_penalty_factor,denoise,preprocess_prompt,postprocess_output, audio/text chunkingsession.cpp:100-116,loader.cpp:34irodori_ttsno_ref,trim_tail,instructionsession.cpp:451-454and the guidance blockindex_tts2do_sample,temperature,top_p,top_k,repetition_penalty,num_beams,length_penaltyindex_tts2/request.cppchatterboxmin_p(its actual truncation filter),top_p,s3gen_cfg_ratechatterbox/session.cppqwen3_ttsx_vector_only_modeqwen3_tts/session.cpp:58minimax_music3minimax_music3/session.cpp,pipeline.cppseed_vcf0_condition,auto_f0_adjust,semitone_shiftseed_vc/session.cpp— without these the SVC entry cannot do what SVC is forvoxcpm1,voxcpm2,heartmula,neutts,vibevoice,stable_audio,ace_step,minimax_h3, the fourfirered-audiogroupsWhat is deliberately left out
The original change also added
reference_max_secondsandreference_pad_mstoomnivoice. Nothing in the tree reads either name —src/models/omnivoicereadsdenoise,duration,guidance_scale,num_inference_steps,preprocess_prompt,postprocess_output,seed,speed,t_shiftand the prefixed session options — so they are not here.Validation
Every added control name was checked against its family's sources, or against the shared chunking helpers in
src/framework/text/chunking.cppandsrc/framework/audio/chunking.cpp.Scope
One data file, 65 controls added. The 20 deletions in the diff are the previous last line of each group gaining a trailing comma. No code change. The generated bundle is deliberately excluded — it is not byte-reproducible, so regenerating it in each PR of this split would make the PRs conflict; happy to send one bundle-regeneration PR once the series lands.