Skip to content

webui: add parameter groups for the TTS and music models that had none - #418

Closed
CryptVenture wants to merge 1 commit into
0xShug0:mainfrom
CryptVenture:pr/params-tts-groups
Closed

webui: add parameter groups for the TTS and music models that had none#418
CryptVenture wants to merge 1 commit into
0xShug0:mainfrom
CryptVenture:pr/params-tts-groups

Conversation

@CryptVenture

Copy link
Copy Markdown
Contributor

Split out of #374 as requested: missing parameter groups, generative families. The analysis groups, the controls added to existing groups, the dead controls, the default overrides and the range fixes are separate PRs.

The problem

Eight TTS and music families had no group at all in model_params.json. The entire control surface of dots_tts, outetts, glm_tts and fish_audio — sampling, guidance, chunking, output format — was reachable only by hand-writing JSON into the fallback box.

The change

Groups added: dots_tts, fish_audio, glm_tts, higgs_audio_tts, muscriptor, outetts, soprano_tts, vietneu_tts — 61 controls.

Every control is named after the key its family reads. text_chunk_size and text_chunk_mode go through the shared overrides in src/framework/text/chunking.cpp:552 and :565, which dots_tts (request.cpp:85-87) and outetts (session.cpp:749) both call.

No existing group is touched, so nothing that worked before changes.

Validation

python3 -m json.tool webui/configs/model_params.json   # parses
python3 tools/check_loader_catalog_sync.py
# ok: runtime loaders, model_specs, and model_manager_v2 are in sync

Every one of the 61 control names was checked against its family's sources, or against the shared chunking helper above.

Scope

One data file, 77 added lines, no deletions. No code change. The generated bundle is deliberately excluded — catalog.ts inlines this file at frontend build time and the bundle is not byte-reproducible, so regenerating it in each PR of this split would make the PRs conflict; happy to send one bundle-regeneration PR once the series lands.

Eight generative families had no group in model_params.json, so the whole
control surface of dots_tts, outetts, glm_tts and fish_audio -- sampling,
guidance, chunking, output format -- was reachable only by hand-writing JSON
in the fallback box.

Groups added: dots_tts, fish_audio, glm_tts, higgs_audio_tts, muscriptor,
outetts, soprano_tts, vietneu_tts. 61 controls, each named after the key its
family reads; text_chunk_size and text_chunk_mode go through the shared
overrides in framework/text/chunking.cpp:552 and :565, which dots_tts
(request.cpp:85-87) and outetts (session.cpp:749) both call.

No existing group is touched.

Validation:
  python3 -m json.tool webui/configs/model_params.json
  python3 tools/check_loader_catalog_sync.py     # in sync
  Every control name checked against the family's own sources.
@CryptVenture

Copy link
Copy Markdown
Contributor Author

Closing for now to stay inside the 3-concurrent-PR policy (see the discussion on #422). Nothing is wrong with the change and CI is green on it; I will reopen it as review slots free.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant