webui: add parameter groups for the TTS and music models that had none - #418
Closed
CryptVenture wants to merge 1 commit into
Closed
webui: add parameter groups for the TTS and music models that had none#418CryptVenture wants to merge 1 commit into
CryptVenture wants to merge 1 commit into
Conversation
Eight generative families had no group in model_params.json, so the whole control surface of dots_tts, outetts, glm_tts and fish_audio -- sampling, guidance, chunking, output format -- was reachable only by hand-writing JSON in the fallback box. Groups added: dots_tts, fish_audio, glm_tts, higgs_audio_tts, muscriptor, outetts, soprano_tts, vietneu_tts. 61 controls, each named after the key its family reads; text_chunk_size and text_chunk_mode go through the shared overrides in framework/text/chunking.cpp:552 and :565, which dots_tts (request.cpp:85-87) and outetts (session.cpp:749) both call. No existing group is touched. Validation: python3 -m json.tool webui/configs/model_params.json python3 tools/check_loader_catalog_sync.py # in sync Every control name checked against the family's own sources.
CryptVenture
force-pushed
the
pr/params-tts-groups
branch
from
September 3, 2026 01:42
4acfcbd to
a9c2240
Compare
Contributor
Author
|
Closing for now to stay inside the 3-concurrent-PR policy (see the discussion on #422). Nothing is wrong with the change and CI is green on it; I will reopen it as review slots free. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split out of #374 as requested: missing parameter groups, generative families. The analysis groups, the controls added to existing groups, the dead controls, the default overrides and the range fixes are separate PRs.
The problem
Eight TTS and music families had no group at all in
model_params.json. The entire control surface ofdots_tts,outetts,glm_ttsandfish_audio— sampling, guidance, chunking, output format — was reachable only by hand-writing JSON into the fallback box.The change
Groups added:
dots_tts,fish_audio,glm_tts,higgs_audio_tts,muscriptor,outetts,soprano_tts,vietneu_tts— 61 controls.Every control is named after the key its family reads.
text_chunk_sizeandtext_chunk_modego through the shared overrides insrc/framework/text/chunking.cpp:552and:565, whichdots_tts(request.cpp:85-87) andoutetts(session.cpp:749) both call.No existing group is touched, so nothing that worked before changes.
Validation
Every one of the 61 control names was checked against its family's sources, or against the shared chunking helper above.
Scope
One data file, 77 added lines, no deletions. No code change. The generated bundle is deliberately excluded —
catalog.tsinlines this file at frontend build time and the bundle is not byte-reproducible, so regenerating it in each PR of this split would make the PRs conflict; happy to send one bundle-regeneration PR once the series lands.