webui: keep parameter ranges inside what the engine accepts - #416
Closed
CryptVenture wants to merge 1 commit into
Closed
webui: keep parameter ranges inside what the engine accepts#416CryptVenture wants to merge 1 commit into
CryptVenture wants to merge 1 commit into
Conversation
Nine minimums sat below the engine's own guard, so a legal-looking slider
position produced a hard 500 rather than a clamped value.
- qwen3_tts temperature, confucius4_tts temperature and top_p, personaplex
and vevo2 temperature: the engines require a positive value
(qwen3_tts/session.cpp:68, confucius4_tts/request.cpp:62-66). Minimums
move off zero.
- dramabox reference_duration_sec, audio_chunk_threshold_sec and
audio_chunk_duration_sec: dramabox/session.cpp:149 throws on a
non-positive reference duration, and the chunk knobs derive frame counts
the same way.
- controlfoley guidance_scale: pipeline.cpp:176 reads it through
positive_float_option, which throws at zero. controlfoley duration_sec now
matches the 0.64 to 60 range the spec declares, instead of 0.1 with no
ceiling; below that floor the derived clip, visual and sync frame counts
round to zero.
- midashenglm_gen min_stop_step: session.cpp:175 parses it as a positive
integer, so 0 was a guaranteed error.
echo_tts num_inference_steps had a maximum equal to its own default, so the
control could only reduce quality; the ceiling moves to 120.
Three controls also lose their default here, for the same reason as the
defaults change: personaplex text_temperature follows temperature when unset,
and vevo2 temperature and top_p are read from the checkpoint's generation
config. They become blank number inputs rather than sliders pinned to a
literal.
Validation:
python3 -m json.tool webui/configs/model_params.json
python3 tools/check_loader_catalog_sync.py # in sync
CryptVenture
force-pushed
the
pr/params-range-fixes
branch
from
September 3, 2026 01:16
e9b4d09 to
6fde74c
Compare
Contributor
Author
|
Closing for now to stay inside the 3-concurrent-PR policy (see the discussion on #422). Nothing is wrong with the change and CI is green on it; I will reopen it as review slots free. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split out of #374 as requested: ranges that let the UI produce hard errors. The dead controls, the default overrides, the missing groups and the label text are separate PRs.
The problem
Nine minimums sat below the engine's own guard, so a legal-looking slider position produced a 500 instead of a clamped value.
qwen3_tts.temperaturesrc/models/qwen3_tts/session.cpp:68— "temperature must be positive when sampling"confucius4_tts.temperaturesrc/models/confucius4_tts/request.cpp:62confucius4_tts.top_psrc/models/confucius4_tts/request.cpp:65— must be in (0, 1]personaplex.temperature,personaplex.text_temperaturevevo2.temperaturedramabox.reference_duration_secsrc/models/dramabox/session.cpp:149dramabox.audio_chunk_threshold_sec,audio_chunk_duration_seccontrolfoley.guidance_scalesrc/models/controlfoley/pipeline.cpp:176reads it throughpositive_float_option, which throws at zerocontrolfoley.duration_secmodel_specs/controlfoley.jsondeclares; below the floor the derived clip/visual/sync frame counts round to zeromidashenglm_gen.min_stop_stepsrc/models/midashenglm_gen/session.cpp:175parses it as a positive integerecho_tts.num_inference_stepshad a maximum equal to its own default, so the control could only reduce quality; the ceiling moves to 120.Also here
Three controls lose their default as well as their range —
personaplex.text_temperature(followstemperaturewhen unset),vevo2.temperatureandvevo2.top_p(read from the checkpoint's generation config). They become blank number inputs rather than sliders pinned to a literal, for the same reason as the sibling defaults PR.Worth flagging separately:
model_specs/controlfoley.jsondeclaresguidance_scalemin 0.0 while the engine throws at zero. That is a spec bug, not a UI one, and belongs to the spec series rather than this PR.Validation
Every bound above was read from the guard named beside it.
Scope
One data file, 14 controls. No code change. The generated bundle is deliberately excluded —
catalog.tsinlines this file at frontend build time and the bundle is not byte-reproducible, so regenerating it in each PR of this split would make the PRs conflict; happy to send one bundle-regeneration PR once the series lands.