webui: drop parameter controls the engine never reads - #414
Closed
CryptVenture wants to merge 1 commit into
Closed
Conversation
Every control in model_params.json is sent with the request, so a control the
engine does not read is a widget that cannot do anything, and in two cases a
widget whose working spelling was missing.
Renamed to the key the engine reads
- index_tts2 "lang" -> "language". index_tts2/request.cpp:90 and
session.cpp:370 read "language"; nothing reads "lang". This is the
multilingual selector on the model whose headline feature is multilingual
cloning, and it had never worked.
- miotts "best_of_n" -> "miotts.best_of_n", the prefixed key declared in
miotts/loader.cpp:33.
- seed_vc "*_cfg_rate" -> "*_guidance_scale". The old spellings survive only
through the deprecation table in seed_vc/session.cpp:83-85; the declared
names are the guidance_scale ones.
Removed
- ace_step's "remix" route and the five controls that existed only to serve
it (source_caption, source_lyrics, flow_edit_n_min/max/avg). The engine
defines its routes in ace_step/session.cpp and throws on anything else;
"remix" appears nowhere in the tree.
- firered-audio-tts top_k, top_p and temperature. firered_audio/session.cpp:
174-182 reads them while building the understanding request, never on the
generation path this group drives.
- echo_tts seed. The server overwrites options["seed"] from the top-level
field (app/server/runtime.cpp:1925), so the control could not take effect.
Validation:
python3 -m json.tool webui/configs/model_params.json
python3 tools/check_loader_catalog_sync.py # in sync
CryptVenture
force-pushed
the
pr/params-dead-controls
branch
from
September 3, 2026 01:16
acce99a to
f26b50f
Compare
Contributor
Author
|
Closing for now to stay inside the 3-concurrent-PR policy (see the discussion on #422). Nothing is wrong with the change and CI is green on it; I will reopen it as review slots free. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split out of #374 as requested: controls the engine does not read. The default overrides, the range fixes, the missing groups and the label text are separate PRs.
Every control in
model_params.jsonis sent with the request, so a control keyed to something the engine never reads is a widget that cannot do anything — and in three cases the working spelling was missing entirely.Renamed to the key the engine actually reads
index_tts2langlanguagesrc/models/index_tts2/request.cpp:90,session.cpp:370readlanguage; nothing readslangmiottsbest_of_nmiotts.best_of_nsrc/models/miotts/loader.cpp:33seed_vc*_cfg_rate×3*_guidance_scale×3src/models/seed_vc/session.cpp:83-85index_tts2is the notable one: that is the multilingual selector, on the model whose headline feature is multilingual cloning, and it had never worked.Removed
ace_step'sremixroute and its five controls (source_caption,source_lyrics,flow_edit_n_min/max/avg). The engine defines its routes insrc/models/ace_step/session.cppand throws on anything else;remixappears nowhere in the tree.firered-audio-ttstop_k,top_p,temperature.src/models/firered_audio/session.cpp:174-182reads them while building the understanding request, never on the generation path this group drives.echo_ttsseed. The server overwritesoptions["seed"]from the top-level field (app/server/runtime.cpp:1925), so the control could not take effect.Validation
Each claim above was checked against the file and line named beside it. The families with no package installed here were not run end to end.
Scope
One data file, 8 insertions / 17 deletions. No code change. The generated bundle is deliberately excluded —
catalog.tsinlines this file at frontend build time and the bundle is not byte-reproducible, so regenerating it in each PR of this split would make the PRs conflict; happy to send one bundle-regeneration PR once the series lands.