webui: fix two strings that rendered wrong - #413
Closed
CryptVenture wants to merge 1 commit into
Closed
Conversation
- The Voice conversion and Source separation tabs are keyed 'conversion' and
'separation', while the subtitle lookups were only defined for 'vc' and
'sep'. Both hero subtitles rendered their raw lookup key. Adds the two
missing keys with the same text the other tabs use.
- The models-folder status line carried a double-encoded ellipsis
("folder…"), which is what a UTF-8 ellipsis looks like after being
decoded as Latin-1. Replaced with the character itself.
Validation:
npx svelte-check --tsconfig ./tsconfig.json # 153 files, 0 errors
CryptVenture
force-pushed
the
pr/webui-string-fixes
branch
from
September 3, 2026 00:50
69331e8 to
1231c89
Compare
Contributor
Author
|
Closing for now to stay inside the 3-concurrent-PR policy (see the discussion on #422). Nothing is wrong with the change and CI is green on it; I will reopen it as review slots free. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split out of #373 as requested. Two string fixes, nothing else; the package resolver, the catalog entries, the request wiring and the transcript display are separate PRs.
The changes
Hero subtitle rendered its lookup key. The workflow tabs are keyed
conversionandseparation, whilestudio.subtitle.*was defined only forvcandsep. The Voice conversion and Source separation tabs printedstudio.subtitle.conversionandstudio.subtitle.separationverbatim where their description should be. Adds the two missing keys.Double-encoded ellipsis in the models-folder status line.
folder…is what a UTF-8 ellipsis looks like after being decoded as Latin-1. Replaced with the character itself.Validation
Scope
Two English strings in
i18n.ts, one status line in+page.svelte. No behaviour change. The generated bundle is deliberately excluded — it is not byte-reproducible, so regenerating it in each PR of this split would make the PRs conflict; happy to send one bundle-regeneration PR once the series lands.