model_specs: declare the MiniMax Music3 and H3 options the sessions read - #407
Closed
CryptVenture wants to merge 1 commit into
Closed
model_specs: declare the MiniMax Music3 and H3 options the sessions read#407CryptVenture wants to merge 1 commit into
CryptVenture wants to merge 1 commit into
Conversation
Additive, and every name below is read by the session today.
- minimax_music3 request options flow_uncond_interval, flow_uncond_warmup,
ensemble_takes, ensemble_prefix_frames and flow_chunk_hop_frames, plus the
minimax_music3.pipeline_overlap session option. They arrived with the
performance pack (minimax_music3/session.cpp, flow_sampler.cpp,
pipeline.cpp) and none were declared; ensemble_takes returns several named
outputs and had no way to be requested at all.
- minimax_h3 request options first_block_cache_start_percent and
first_block_cache_end_percent (minimax_h3/session.cpp, pipeline.cpp). These
are the primary cache window whose _sigma override was already declared, so
the spec exposed the fine adjustment while hiding the control it adjusts.
No existing declaration changes, so no request that validated before fails now.
CryptVenture
force-pushed
the
pr/spec-minimax-options
branch
from
September 3, 2026 00:26
31398f8 to
741e4e9
Compare
Contributor
Author
|
Closing for now to stay inside the 3-concurrent-PR policy (see the discussion on #422). Nothing is wrong with the change and CI is green on it; I will reopen it as review slots free. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split out of #372 as requested. This PR declares the MiniMax Music3 and H3 options their sessions already read; the description-only fixes, the VoxCPM1 defaults, the strict contract fixes and the ASR/aligner/codec declarations are separate PRs.
Additive throughout: no existing declaration changes, so nothing that validated before fails now.
The changes
minimax_music3— five request options and one session option, all read today:flow_uncond_intervalsrc/community_models/minimax_music3/flow_sampler.cpp,session.cppflow_uncond_warmupsrc/community_models/minimax_music3/flow_sampler.cpp,session.cppensemble_takessrc/community_models/minimax_music3/session.cppensemble_prefix_framessrc/community_models/minimax_music3/pipeline.cpp,session.cppflow_chunk_hop_framessrc/community_models/minimax_music3/pipeline.cpp,session.cppminimax_music3.pipeline_overlapsrc/community_models/minimax_music3/pipeline.cpp,session.cppThese arrived with the performance pack and none were declared.
ensemble_takesreturns several named outputs and had no way to be requested at all.minimax_h3—first_block_cache_start_percentandfirst_block_cache_end_percent(src/community_models/minimax_h3/session.cpp,pipeline.cpp). This is the primary cache window whose_sigmaoverride was already declared, so the spec exposed the fine adjustment while hiding the control it adjusts.Validation
Verified by reading the option-parsing code named above. Neither package is installed on this machine, so no end-to-end generation was run.
Scope
Two spec files, +66. The generated WebUI bundle is deliberately excluded —
catalog.tsinlinesmodel_specs/*.jsonat frontend build time and the bundle is not byte-reproducible, so regenerating it in every PR of this split would make the PRs conflict with each other. Happy to send one bundle-regeneration PR once the series lands.